Hello, [...] > > > + if (reg_val & PIPE_CLK_STABLE) > > > + return dev_err_probe(dev, -EINVAL, > > > + "PIPE clk is not stable\n"); > > > > I guess this is a timeout issue, so -ETIMEDOUT. > > I can update this directly on the branch. Done. [...] > > > + if (!dev->of_node) > > > + return dev_err_probe(dev, -EINVAL, "NULL node\n"); > > > > This check is pointless, so you should drop it. Done. [...] > > > + if (!data) > > > + return dev_err_probe(dev, -EINVAL, "OF data missing\n"); > > > > -ENODATA > > Almost all of the other drivers return -EINVAL in this case. > > We can update this here, but I wonder if a follow-up patch to update other > drivers accordingly where it makes sense of course, would be better here? > > Thoughts? I left this one as-is for now. Krzysztof
