Hello,
> If the bitmap allocations fail then dw_pcie_ep_init_registers() currently
> returns success. Return -ENOMEM instead.
[...]
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -908,6 +908,7 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep)
> if (ret)
> return ret;
>
> + ret = -ENOMEM;
> if (!ep->ib_window_map) {
> ep->ib_window_map = devm_bitmap_zalloc(dev, pci->num_ib_windows,
> GFP_KERNEL);
Nice catch!
This will cover subsequent calls to devm_bitmap_zalloc() and devm_kcalloc().
Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
Thank you!
Krzysztof
