On Sat, Aug 31, 2024 at 12:04:08PM +0800, Zhang Zekun wrote:
> for_each_available_child_of_node_scoped() provides a scope-based cleanup
> functionality to put the device_node automatically, and we don't need to
> call of_node_put() directly. Let's simplify the code a bit with the use
> of these functions.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
- Mani
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> ---
> v2:
> Fix spelling error in commit message.
>
> drivers/pci/controller/dwc/pcie-kirin.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
> index 0a29136491b8..e9bda1746ca5 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -452,7 +452,7 @@ static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie,
> struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct device_node *child, *node = dev->of_node;
> + struct device_node *node = dev->of_node;
> void __iomem *apb_base;
> int ret;
>
> @@ -477,17 +477,13 @@ static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie,
> return ret;
>
> /* Parse OF children */
> - for_each_available_child_of_node(node, child) {
> + for_each_available_child_of_node_scoped(node, child) {
> ret = kirin_pcie_parse_port(kirin_pcie, pdev, child);
> if (ret)
> - goto put_node;
> + return ret;
> }
>
> return 0;
> -
> -put_node:
> - of_node_put(child);
> - return ret;
> }
>
> static void kirin_pcie_sideband_dbi_w_mode(struct kirin_pcie *kirin_pcie,
> --
> 2.17.1
>
--
மணிவண்ணன் சதாசிவம்
