On Thu, Feb 13, 2025 at 06:35:37PM -0800, Jon Pan-Doh wrote:
> From: Karolina Stolarek <karolina.stolarek@xxxxxxxxxx>
>
> When reporting an AER error, we check its type multiple times
> to determine the log level for each message. Do this check only
> in the top-level function and propagate the result down the call
> chain. Make aer_print_port_info output to match the level of the
> reported error.
Can you mention the top-level function name? I guess it's
aer_isr_one_error()? Nit: add "()" after function names.
It *might* be possible to split this into two patches:
- Check level once and propagate down. This would include the
changes to aer_isr_one_error(), aer_process_err_devices(),
aer_print_error(), __aer_print_error(), and probably
dpc_process_error(). It looks like this wouldn't change the
levels of any messages.
- Change log levels. It looks like the main place is
pci_print_aer(), which previously always used pci_err() and would
now use either KERN_WARNING or KERN_ERR.
pcie_print_tlp_log() also always uses pci_err(). Maybe that's only
used for Uncorrectable errors? I'm not sure what the rules are for
the Header Log.
Bjorn
