On Fri, Feb 14, 2025 at 12:39:29PM -0500, Jim Quinlan wrote:
> When the user elects to limit the PCIe generation via the appropriate DT
> property, apply the settings before the PCIe link-up, not after.
>
> Fixes: c0452137034bda8f686dd9a2e167949bfffd6776 ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
>
Common practice is to use the 12 chars SHA for Fixes tag and not the entire 40
chars. Like,
Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
And no need of extra newline here.
> Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
- Mani
> ---
> drivers/pci/controller/pcie-brcmstb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 546056f7f0d3..64a7511e66a8 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1324,6 +1324,10 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
> bool ssc_good = false;
> int ret, i;
>
> + /* Limit the generation if specified */
> + if (pcie->gen)
> + brcm_pcie_set_gen(pcie, pcie->gen);
> +
> /* Unassert the fundamental reset */
> ret = pcie->cfg->perst_set(pcie, 0);
> if (ret)
> @@ -1350,9 +1354,6 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
>
> brcm_config_clkreq(pcie);
>
> - if (pcie->gen)
> - brcm_pcie_set_gen(pcie, pcie->gen);
> -
> if (pcie->ssc) {
> ret = brcm_pcie_set_ssc(pcie);
> if (ret == 0)
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
