Hello, [...] > > > What will happen if ret != 0? still return 0? > > > > Given that callers of dwc_pcie_debugfs_init() check for errors, > > this probably should correctly bubble up any failure coming from > > dwc_pcie_rasdes_debugfs_init(). > > > > I made updates to the code directly on the current branch, have a look: > > > > https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=1ff54f4cbaed9ec6994844967c36cf7ada4cbe5e > > > > Let me know if this is OK with you. > > It looks good to me. > > Feel free to add, > Reviewed-by: Fan Ni <fan.ni@xxxxxxxxxxx> Will do. Thank you. Krzysztof
