Re: [PATCH v2 7/8] PCI/AER: Add AER sysfs attributes for log ratelimits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 25, 2025 at 5:56 AM Karolina Stolarek
<karolina.stolarek@xxxxxxxxxx> wrote:
> On 14/02/2025 03:35, Jon Pan-Doh wrote:
> > +
> > +static struct attribute *aer_attrs[] __ro_after_init = {
>                                         ^^^^^^^^^^^^^^^
> This is a copy-paste error. These attributes are in the read-only region
> and can't be written to, so please remove it in the next version.

Ack.

> Also, what value do we have to write to turn off ratelimiting
> completely? Can we handle that as a special case?

Not something I originally planned, but can add it in v3. Given the
permanence of sysfs entries, would we want one toggle for all
ratelimiting (logs and potentially IRQs) or separate ones?

Thanks,
Jon





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux