Re: [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global' interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/27/2025 3:03 AM, Krzysztof Kozlowski wrote:
On 26/02/2025 17:29, Bjorn Andersson wrote:
@@ -54,7 +54,7 @@ properties:
interrupts:
      minItems: 8
-    maxItems: 8
+    maxItems: 9
interrupt-names:
      items:
@@ -66,6 +66,7 @@ properties:
        - const: msi5
        - const: msi6
        - const: msi7
+      - const: global

Either context is missing or these are not synced with interrupts.


I think the patch context ("properties") is confusing here, but it looks
to me that these are in sync: interrupts is defined to have 8 items, and
interrupt-names is a list of msi0 through msi7.

interrupt-names has minItems 9 in this case, so they are not synced.
That's my concern

Ok I will update the minItems to 9 as suggested.

- Krishna Chaitanya.

Best regards,
Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux