Re: [PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/02/2025 09:38, Kever Yang wrote:
>>>   
>>>   additionalProperties: true
>>>   
>>> +anyOf:
>> There is never syntax like that. Where did you find it (so we can fix
>> it)?


... therefore please use existing code as examples instead of coming
with entirely new syntax.

>>
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: rockchip,rk3576-pcie
>> This does not belong to common schema, but to device specific. I don't
>> see this compatible in this common schema at all.
> 
> The common schema covers rockchip-dw-pcie.yaml and rockchip-dw-pcie-ep.yaml,
> 
> so I though I should add the if condition here.


You do not have compatibles here so you cannot add here code depending
on compatibles.

Best regards,
Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux