Hello, [...] > Can you include something here about what the issue is? Based on the > subject line and the patch, I assume something is wrong with the ATS > Capability? I guess this is some kind of rk3588 defect, right? > > > Usually, to handle these issues, we add a quirk for the PCI vendor and > > device ID in drivers/pci/quirks.c with quirk_no_ats(). That is because > > we cannot usually modify the capabilities on the EP side. > > > > In this case, we can modify the capabilties on the EP side. Thus, hide the > > broken ATS capability on rk3588 when running in EP mode. That way, > > we don't need any quirk on the host side, and we see no errors on the host > > side, and we can run pci_endpoint_test successfully, with the IOMMU > > enabled on the host side. Rockchip folks, anything to add about this issue? Perhaps there is an erratum about this? Any code reviews? Anything? Western Digital folks are doing you a lot of favour with all the upstream work they do maintaining drivers for your platforms. But it would be nice if Rockchip took some ownership. I have seen none recently. No reviews, not even an Acked-by, nothing. A bit of a letdown, if you ask me. Thank you! Krzysztof
