On 2/7/25 06:34, Jason Gunthorpe wrote:
On Thu, Feb 06, 2025 at 07:03:38PM -0800, Tushar Dave wrote:Commit 47c8846a49ba ("PCI: Extend ACS configurability") introduced bugs that fail to configure ACS ctrl to the value specified by the kernel parameter. Essentially there are two bugs. First, when ACS is configured for multiple PCI devices using 'config_acs' kernel parameter, it results into error "PCI: Can't parse ACS command line parameter". This is due to the bug in code that doesn't preserve the ACS mask instead overwrites the mask with value 0...Fixes: 47c8846a49ba ("PCI: Extend ACS configurability") Signed-off-by: Tushar Dave <tdave@xxxxxxxxxx> --- changes in v2: - Addressed review comments by Jason and Bjorn. - Removed Documentation changes (already taken care by other patch). - Amended commit description. drivers/pci/pci.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason
Hi Bjorn, Gentle reminder. Let me know if there are any review comments! Thanks. -Tushar
