Re: [PATCH v2 7/8] PCI/AER: Add AER sysfs attributes for log ratelimits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 17, 2025 at 5:31 AM Karolina Stolarek
<karolina.stolarek@xxxxxxxxxx> wrote:
> The convention is that sysfs files should provide one value per file. It
> won't be just people interacting with this interface, but scripts as
> well. Parsing such a string is a hassle. As we can only change the burst
> of the ratelimit, I'd simply emit pdev->aer_report->ratelimit.burst.

Realized that Jonathan said something similar in v1[1] (that I forgot
to fix). In addition to the reason you provided, he stated that
convention is to read/write the same thing to a sysfs file.

[1] https://lore.kernel.org/linux-pci/20250131143246.000037a2@xxxxxxxxxx/

Thanks,
Jon





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux