On Mon, Feb 17, 2025 at 3:29 AM Karolina Stolarek <karolina.stolarek@xxxxxxxxxx> wrote: > On 14/02/2025 03:35, Jon Pan-Doh wrote: > > Tested using aer-inject[1]. AER sysfs counters still updated correctly. > > I don't think we have to mention that it was tested. In other patches > you mention specific examples that illustrate the change nicely, but we > don't get the same value from the statement above. Ack. Will omit in v3. > With this change, we increment the stats when we iterate the recovery > queue in ghes_handle_aer. Is there a possibility that in the GHES path > we would increment the stats twice? First via AER module (aer_isr) and > then in aer_recover_work_func, or is it either/or? It's either/or. aer_isr deals with native AER handling (i.e. by OS). However, AER errors from GHES originate from ACPI APEI (i.e. FW notifies OS of error). Thanks, Jon