On Thu, Feb 6, 2025 at 5:20 PM Stefan Wahren <wahrenst@xxxxxxx> wrote: > > Hi Jim, > > Am 05.02.25 um 20:12 schrieb Jim Quinlan: > > Just make it clear to the reader that there is a conversion happening, > > in this case from an int type to an irq_hw_number_t, an unsigned long int. > I'm not a fan of this generic subject. A possible suggestion might be: > > PCI: brcmstb: Clarify conversion by irq_domain_set_info ack > > Regards > > > > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx> > > --- > > drivers/pci/controller/pcie-brcmstb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > > index da7b10036948..1e24e7fc895c 100644 > > --- a/drivers/pci/controller/pcie-brcmstb.c > > +++ b/drivers/pci/controller/pcie-brcmstb.c > > @@ -560,7 +560,7 @@ static int brcm_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, > > return hwirq; > > > > for (i = 0; i < nr_irqs; i++) > > - irq_domain_set_info(domain, virq + i, hwirq + i, > > + irq_domain_set_info(domain, virq + i, (irq_hw_number_t)hwirq + i, > > &brcm_msi_bottom_irq_chip, domain->host_data, > > handle_edge_irq, NULL, NULL); > > return 0; >
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
