Terry Bowman wrote: > The AER service driver enables PCIe Uncorrectable Internal Errors (UIE) and > Correctable Internal errors (CIE) for CXL Root Ports. The UIE and CIE are > used in reporting CXL Protocol Errors. The same UIE/CIE enablement is > needed for CXL Upstream Switch Ports and CXL Downstream Switch Ports > inorder to notify the associated Root Port and OS.[1] > > Export the AER service driver's pci_aer_unmask_internal_errors() function > to CXL namespace. > > Remove the function's dependency on the CONFIG_PCIEAER_CXL kernel config > because it is now an exported function. > > Call pci_aer_unmask_internal_errors() during RAS initialization in: > cxl_uport_init_ras_reporting() and cxl_dport_init_ras_reporting(). > > [1] PCIe Base Spec r6.2-1.0, 6.2.3.2.2 Masking Individual Errors > > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> I wonder if this should save+unmask and restore the prior state when the cxl_port detaches from the port driver? I guess we can wait to see if this causes problems since internal errors should be more predictable / reliable on CXL devices compared to generic PCIe devices where Linux never enabled internal errors previously.
