Re: [PATCH 2/8] PCI/AER: Move AER stat collection out of __aer_print_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 24, 2025 at 8:37 PM Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> Isn't pci_print_ear() internally calls __aer_print_error()? So the stat
> collection
> should work fine even now. Can you give more info on why you want to
> decouple here.

Sure. From a readability perspective, I think that it is better to not
have stat collection buried in print functions. This allows the print
functions to be side-effect free as well (more or less).

One of the outstanding items is to unify the {aer, pci)_print_error()
paths, which may alter where we do the stat collection. However, I
think the general idea stands.

Thanks,
Jon





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux