Bowman, Terry wrote: [..] > > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Ok. I can add is_cxl to 'struct aer_err_info'. Shall I set it by reading the > alternate protocol link state? I am thinking no because dev->is_cxl at least indicates that a CXL link was up at some point, and racing CXL link down is not something the error core can reasonably mitigate. In the end I think that it should be something like: info->is_cxl = dev->is_cxl && is_internal_error() ...on the expectation that a CXL device is unlikely to multiplex internal errors across CXL protocol error events and device-specific internal events. Even if a device *did* multiplex those I think it is reasonable for the kernel to treat a device-specific UCE the same as a CXL protocol UCE and panic the system.
