Re: [PATCH v1] Support BT remote wake.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Chandrashekar,


Thank you for your patch. Several comments on formal things.


Am 11.02.25 um 12:26 schrieb Chandrashekar Devegowda:

Your system time is set incorrectly and set to the future.

Changes to add hdev->wakeup call to support wake on BT feature.

Please elaborate. What is the problem? How is it solved? How is it tested?

Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@xxxxxxxxx>
Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
---
changes in v1:
     - support for BT remote wake.

Not necessary to note v1 changes.

  drivers/bluetooth/btintel_pcie.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index b8b241a92bf9..e0633fab55a0 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -1509,6 +1509,13 @@ static int btintel_pcie_setup(struct hci_dev *hdev)
  	return err;
  }
+static bool btintel_pcie_wakeup(struct hci_dev *hdev)
+{
+	struct btintel_pcie_data *data = hci_get_drvdata(hdev);
+
+	return device_may_wakeup(&data->pdev->dev);
+}
+
  static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data)
  {
  	int err;
@@ -1533,6 +1540,7 @@ static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data)
  	hdev->hw_error = btintel_hw_error;
  	hdev->set_diag = btintel_set_diag;
  	hdev->set_bdaddr = btintel_set_bdaddr;
+	hdev->wakeup = btintel_pcie_wakeup;
err = hci_register_dev(hdev);
  	if (err < 0) {

The diff looks good.


Kind regards,

Paul




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux