On Mon, Feb 10, 2025 at 02:25:43PM +0000, Vidya Sagar wrote:
> Thanks Niklas for the review.
> I'll rewrite the commit message add the following line
> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
>
No, please. Try to use the generic ARCH symbol dependency as suggested.
- Mani
> Thanks
> Vidya Sagar
>
> ________________________________
> From: Niklas Cassel <cassel@xxxxxxxxxx>
> Sent: Tuesday, January 28, 2025 17:34
> To: Vidya Sagar <vidyas@xxxxxxxxxx>
> Cc: lpieralisi@xxxxxxxxxx <lpieralisi@xxxxxxxxxx>; kw@xxxxxxxxx <kw@xxxxxxxxx>; manivannan.sadhasivam@xxxxxxxxxx <manivannan.sadhasivam@xxxxxxxxxx>; robh@xxxxxxxxxx <robh@xxxxxxxxxx>; bhelgaas@xxxxxxxxxx <bhelgaas@xxxxxxxxxx>; quic_schintav@xxxxxxxxxxx <quic_schintav@xxxxxxxxxxx>; johan+linaro@xxxxxxxxxx <johan+linaro@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx <linux-pci@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>; Thierry Reding <treding@xxxxxxxxxx>; Jon Hunter <jonathanh@xxxxxxxxxx>; Krishna Thota <kthota@xxxxxxxxxx>; Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx>; sagar.tv@xxxxxxxxx <sagar.tv@xxxxxxxxx>
> Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms
>
> External email: Use caution opening links or attachments
>
>
> Hello Vidya,
>
> On Tue, Jan 28, 2025 at 10:12:44AM +0530, Vidya Sagar wrote:
> > Add PCIe RC & EP support for Tegra234 Platforms.
>
> The commit log does leave quite a few questions unanswered.
>
> Since you are just updating the Kconfig and nothing else:
> Does the DT binding already have support for the Tegra234 SoC?
> Does the driver already have support for the Tegra234 SoC?
>
> Looking at the DT binding and driver, the answer to both questions
> is yes. (This should have been in the commit message IMO.)
>
>
> But that leads me to the question, since there is support for Tegra234
> SoC in the driver, does this means that this fixes a regression, e.g.
> the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in
> this driver was added. In this case, you should have a Fixes: tag that
> points to the commit that added ARCH_TEGRA_234_SOC.
>
> Or has the the driver support for Tegra234 been "dead-code" since it
> was originally added? (Because without this patch, no one can have
> tested it, at least not without COMPILE_TEST.)
> In this case, you should add:
> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
>
>
> Kind regards,
> Niklas
--
மணிவண்ணன் சதாசிவம்
