On Fri, Feb 07, 2025 at 01:08:35PM -0600, Bowman, Terry wrote: > > >> + > >> + if (dev_is_cxl_pci(dport_dev, PCI_EXP_TYPE_DOWNSTREAM) || > >> + dev_is_cxl_pci(dport_dev, PCI_EXP_TYPE_ROOT_PORT)) > > Mostly an observation - this kind of comparison seems to be coming up > > more. Wonder if an explicit set of APIs for these checks would be worth > > it to clean up the 3 or 4 different comparison variants i've seen. > > > > Either way > > > > Reviewed-by: Gregory Price <gourry@xxxxxxxxxx> > > > > ~Gregory > Do you recommend moving dev_is_cxl_pci() to pci library as is? Thanks for 'Reviewed-by:`. Terry I'd have to go look around and see how much the PCI_EXP_TYPE items are being used for comparison and how - I was just commenting internally on this patch set. If this set is the only place it's being used (so far) then it's probably not worth extra work yet. ~Gregory
