On Tue, Feb 04, 2025 at 12:06:41PM +0100, Niklas Cassel wrote:
> Commit f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value")
> changed the return value of pci_endpoint_test_bars_read_bar() from false
> to -EINVAL on error, however, it failed to update the error handling.
>
> Fixes: f26d37ee9bda ("misc: pci_endpoint_test: Fix IOCTL return value")
> Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
- Mani
> ---
> Changes since v1:
> -Changed the type of the variable ret to int to match the new return type.
>
> drivers/misc/pci_endpoint_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index d5ac71a49386..7584d1876859 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -382,7 +382,7 @@ static int pci_endpoint_test_bars_read_bar(struct pci_endpoint_test *test,
> static int pci_endpoint_test_bars(struct pci_endpoint_test *test)
> {
> enum pci_barno bar;
> - bool ret;
> + int ret;
>
> /* Write all BARs in order (without reading). */
> for (bar = 0; bar < PCI_STD_NUM_BARS; bar++)
> @@ -398,7 +398,7 @@ static int pci_endpoint_test_bars(struct pci_endpoint_test *test)
> for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> if (test->bar[bar]) {
> ret = pci_endpoint_test_bars_read_bar(test, bar);
> - if (!ret)
> + if (ret)
> return ret;
> }
> }
> --
> 2.48.1
>
--
மணிவண்ணன் சதாசிவம்
