On Tue, Jan 14, 2025 at 04:23:56PM -0600, Ira Weiny wrote: > Terry Bowman wrote: > > CXL PCIe Port Protocol Error support will be added in the future. This > > requires searching for a CXL PCIe Port device in the CXL topology as > > provided by find_cxl_port(). But, find_cxl_port() is defined static > > and as a result is not callable outside of this source file. > > > > Update the find_cxl_port() declaration to be non-static. > > > > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Generally I think Dan prefers this type of patch to be squashed with the > patch which requires the change. But I'm ok with the smaller patches... > > :-D > > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> > I've read elsewhere that changelog entries should avoid telling the future - and simply state what the patch is doing. I.e.: "do the thing" as opposed to "In the future... so do the thing" The existence of the patch implies there is a user for it. anyway Reviewed-by: Gregory Price <gourry@xxxxxxxxxx>
