On Fri, Jan 24, 2025 at 10:33:01AM +0100, Niklas Cassel wrote: > Running 'pcitest -b 0' fails with "TEST FAILED" when the BAR0 size > is e.g. 8 GB. > > The return value of the pci_resource_len() macro can be larger than that > of a signed integer type. Thus, when using 'pcitest' with an 8 GB BAR, > the bar_size of the integer type will overflow. > > Change bar_size from integer to resource_size_t to prevent integer > overflow for large BAR sizes with 32-bit compilers. > > In order to handle 64-bit resource_type_t on 32-bit platforms, we would > have needed to use a function like div_u64() or similar. Instead, change > the code to use addition instead of division. This avoids the need for > div_u64() or similar, while also simplifying the code. > Fixes tag? > Co-developed-by: Hans Zhang <18255117159@xxxxxxx> > Signed-off-by: Hans Zhang <18255117159@xxxxxxx> > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > --- > Changes since v1: > -Add reason for why division was changed to addition in commit log. You removed the history of this patch that was present in v1. Since there is no link to v1, you could've kept it here for the sake of completeness. - Mani -- மணிவண்ணன் சதாசிவம்
