On Wed, Jan 29, 2025 at 05:39:18PM +0100, Niklas Cassel wrote: > Hello Frank, > > On Wed, Jan 29, 2025 at 10:28:23AM -0500, Frank Li wrote: > > On Wed, Jan 29, 2025 at 11:13:42AM +0100, Niklas Cassel wrote: > > > > > > Please don't shoot the messenger, but I don't see any reply to (what I > > > assume is the biggest reason why Bjorn did not merge this series): > > > > > > "" > > > .cpu_addr_fixup() is a generic problem that affects dwc (dra7xx, imx6, > > > artpec6, intel-gw, visconti), cadence (cadence-plat), and now > > > apparently microchip. > > > > > > I deferred these because I'm hoping we can come up with a more generic > > > solution that's easier to apply across all these cases. I don't > > > really want to merge something that immediately needs to be reworked > > > for other drivers. > > > "" > > > > > > It should probably state in the cover letter how v9 addresses Bjorn's > > > concern when it comes to other PCI controller drivers, especially those > > > that are not DWC based. > > > > Thank you for your reminder, I forget mentions this in cover letter. I > > create new patch to figure out this Bjorn's problem. > > > > PCI: Add parent_bus_offset to resource_entry > > I see. > > If you are solving this problem in a generic way, then it would make sense > if the generic patch comes first in the series, and then the driver (DWC) > specific patches come after that. > > Your cover letter, including the subject is also written in a DWC specific > manner. > > If you are solving a generic problem, then describe first how you solve > the generic problem, followed by DWC specific details. > > See e.g. my cover letter here: > https://lore.kernel.org/linux-pci/20250119050850.2kogtpl5hatpp2tv@thinkpad/T/#t Thanks, let's wait for Bjorn's comments about new method. I will do that next time if need respin. Frank > > > Kind regards, > Niklas
