On Mon, Jan 13, 2025 at 11:27:33AM +0100, Niklas Cassel wrote:
> Move dw_pcie_ep_find_ext_capability() so that it is located next to
> dw_pcie_ep_find_capability().
>
> Additionally, a follow-up commit requires this to be defined earlier
> in order to avoid a forward declaration.
>
> Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
- Mani
> ---
> .../pci/controller/dwc/pcie-designware-ep.c | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 8e07d432e74f..6b494781da42 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -102,6 +102,24 @@ static u8 dw_pcie_ep_find_capability(struct dw_pcie_ep *ep, u8 func_no, u8 cap)
> return __dw_pcie_ep_find_next_cap(ep, func_no, next_cap_ptr, cap);
> }
>
> +static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap)
> +{
> + u32 header;
> + int pos = PCI_CFG_SPACE_SIZE;
> +
> + while (pos) {
> + header = dw_pcie_readl_dbi(pci, pos);
> + if (PCI_EXT_CAP_ID(header) == cap)
> + return pos;
> +
> + pos = PCI_EXT_CAP_NEXT(header);
> + if (!pos)
> + break;
> + }
> +
> + return 0;
> +}
> +
> static int dw_pcie_ep_write_header(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> struct pci_epf_header *hdr)
> {
> @@ -690,24 +708,6 @@ void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)
> }
> EXPORT_SYMBOL_GPL(dw_pcie_ep_deinit);
>
> -static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap)
> -{
> - u32 header;
> - int pos = PCI_CFG_SPACE_SIZE;
> -
> - while (pos) {
> - header = dw_pcie_readl_dbi(pci, pos);
> - if (PCI_EXT_CAP_ID(header) == cap)
> - return pos;
> -
> - pos = PCI_EXT_CAP_NEXT(header);
> - if (!pos)
> - break;
> - }
> -
> - return 0;
> -}
> -
> static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci)
> {
> unsigned int offset;
> --
> 2.47.1
>
--
மணிவண்ணன் சதாசிவம்
