Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-07-26 at 00:36 +0200, Bjørn Mork wrote:
> "Rafael J. Wysocki" <rjw@xxxxxxx> writes:
> 
> > This is not really necessary.  The problem is the change of behavior I was
> > worried about some time ago.
> >
> > Namely, the device in question apparently doesn't support ACPI D3_hot,
> > so acpi_pm_device_sleep_state() returns D2 as the target state, where it
> > would return D3(cold) before the commit in question.
> >
> > To fix the regression, we'd need to reverse the current initial value of
> > the d3cold_allowed flag so that it is set to "true" by default and only
> > set to "false" for devices where we suspect there may be problems with
> > D3_cold (like PCI Express ports).
> 
> Good.  May I also request a few lines describing d3cold_allowed in e.g
> Documentation/ABI/testing/sysfs-bus-pci?  I must admit that I thought
> that was the policy for any new sysfs file, but it seems that is only
> in the USB subsystem?
> 
> Anyway, I believe it ought to be a requirement.  If we are meant to
> tweak some knob, then we must known how and when to do so.  If not, then
> why add it in the first place?

Yes.  I should have added the ABI document.  Will write a patch for
that.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux