> On Mi, 2025-01-15 at 18:58 +0100, Lorenzo Bianconi wrote:
> > Remove a leftover assert for mac_reset line in mtk_pcie_en7581_power_up().
> > This is not armful since EN7581 does not requires mac_reset and
> ^ harmful
ack, I will fix it.
>
> > mac_reset is not defined in EN7581 device tree.
> >
>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > ---
> > drivers/pci/controller/pcie-mediatek-gen3.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> > index aa24ac9aaecc749b53cfc4faf6399913d20cdbf2..0f64e76e2111468e6a453889ead7fbc75804faf7 100644
> > --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> > @@ -940,7 +940,6 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie)
> > */
> > reset_control_bulk_assert(pcie->soc->phy_resets.num_resets,
> > pcie->phy_resets);
> > - reset_control_assert(pcie->mac_reset);
>
> Is it ok to keep the mac_reset assert in mtk_pcie_power_down() ?
yes, since it is in common between mtk chipset and airoha one.
reset_control_assert() just returns if rstc is NULL.
>
> > /* Wait for the time needed to complete the reset lines assert. */
> > msleep(PCIE_EN7581_RESET_TIME_MS);
> >
> > ---
> > base-commit: d02e16e4e05d5d2530a4836ca92318c6a6b21b01
>
> I can't find this commit, which tree is it on?
it is in next tree:
commit d02e16e4e05d5d2530a4836ca92318c6a6b21b01
Merge: 07eecfa5d467 9dfc6850cfa4
Author: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx>
Date: Wed Jan 15 13:56:57 2025 +0000
Merge branch 'resource'
* resource:
PCI: Encourage resource request API users to supply driver name
Regards,
Lorenzo
>
> regards
> Philipp
Attachment:
signature.asc
Description: PGP signature
