On Mon, Jan 06, 2025 at 09:00:38PM +0530, Anand Moon wrote: Subject should include the word 'fix' not 'improve' > Updates the error message to include the actual return value of s/Updates/Update (imperative form) > devm_clk_bulk_get_all, which provides more context for debugging > and troubleshooting the root cause of clock retrieval failures. > Btw, it is not just updating the error message, it also returns the actual error code. - Mani > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/r/202501040409.SUV09R80-lkp@xxxxxxxxx/ > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx> > --- > drivers/pci/controller/pcie-rockchip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index fea867c24f75..ca6163f9d2dd 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -99,7 +99,8 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) > > rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks); > if (rockchip->num_clks < 0) > - return dev_err_probe(dev, err, "failed to get clocks\n"); > + return dev_err_probe(dev, rockchip->num_clks, > + "failed to get clocks\n"); > > return 0; > } > -- > 2.47.1 > -- மணிவண்ணன் சதாசிவம்
