On Wed, Jan 08, 2025 at 03:40:11PM -0500, Yazen Ghannam wrote: > On Wed, Dec 18, 2024 at 04:37:43PM +0200, Ilpo Järvinen wrote: > > pcie_read_tlp_log()'s prototype and function signature diverged due to > > changes made while applying. > > > > Make the parameters of pcie_read_tlp_log() named identically. > > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx> > > Just wondering, could this be squashed into the previous patch? Or is > the goal to be strict with one logical change per patch? I haven't looked closely enough to opine on whether this should be squashed, but I generally do prefer one logical change per patch. It's much easier for me to squash things when merging than it is to untangle things that should be separate patches. Bjorn
