On Fri, 2025-01-03 at 13:15 -0600, Bjorn Helgaas wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Fri, Jan 03, 2025 at 02:00:13PM +0800, Jianjun Wang wrote: > > Disable ASPM L0s support because it does not significantly save > > power > > but impacts performance. > > This seems like a user/administrator decision, not a driver decision. > > L0s reduces power at the cost of performance for *all* PCIe devices, > although the actual numbers may vary. We have encountered some compatibility issues when connected with some PCIe EPs, these issues are probabilistic and disabling the L0s can fix them. Users may not be aware of these issues, so I think disabling L0s through the driver might be the better way, since it does not significantly save power and we usually use L1ss for power-saving when the link is idle. Thanks.
