On Fri, Jan 03, 2025 at 03:31:28PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> of_pci_parse_bus_range() looks for a DT "bus-range" property. If none
> exists, devm_of_pci_get_host_bridge_resources() defaults to the [bus 00-ff]
> range supplied by its caller, pci_parse_request_of_pci_ranges().
>
> devm_of_pci_get_host_bridge_resources() is static and has no other callers,
> so there's no reason to complicate its interface by passing the default bus
> range.
> @@ -343,8 +340,8 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev,
>
> err = of_pci_parse_bus_range(dev_node, bus_range);
> if (err) {
> - bus_range->start = busno;
> - bus_range->end = bus_max;
> + bus_range->start = 0;
> + bus_range->end = 0xff;
> bus_range->flags = IORESOURCE_BUS;
> dev_info(dev, " No bus range found for %pOF, using %pR\n",
> dev_node, bus_range);
Hmm, would have been better if I'd compiled this first to notice the
build error, sorry about that:
drivers/pci/of.c: In function ‘devm_of_pci_get_host_bridge_resources’:
drivers/pci/of.c:349:57: error: ‘bus_max’ undeclared (first use in this function)
349 | if (bus_range->end > bus_range->start + bus_max)
| ^~~~~~~
Will fix.
