Change dw_pcie_edma_irq_verify() to print the dma channel as %u.
While a DWC glue driver could theoretically initialize nr_irqs to a
negative value, doing so would obviously be incorrect, and the later
dw_edma_probe(struct dw_edma_chip *chip) call would fail, since while
the dw_edma_probe() call expects the caller to initialize chip->nr_irqs,
dw_edma_probe() verifies nr_irqs and returns failure if nr_irqs is < 1.
This fixes the following build warning when compiling with W=1:
drivers/pci/controller/dwc/pcie-designware.c: In function ‘dw_pcie_edma_detect’:
drivers/pci/controller/dwc/pcie-designware.c:989:50: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Wformat-truncation=]
989 | snprintf(name, sizeof(name), "dma%d", pci->edma.nr_irqs);
| ^~
Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx>
---
Changes since V1:
-Do not reject negative nr_irqs value in dw_pcie_edma_irq_verify(),
as this will already be done by dw_edma_probe().
drivers/pci/controller/dwc/pcie-designware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 3c683b6119c3..0a13fb4336f4 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -986,7 +986,7 @@ static int dw_pcie_edma_irq_verify(struct dw_pcie *pci)
}
for (; pci->edma.nr_irqs < ch_cnt; pci->edma.nr_irqs++) {
- snprintf(name, sizeof(name), "dma%d", pci->edma.nr_irqs);
+ snprintf(name, sizeof(name), "dma%u", pci->edma.nr_irqs);
ret = platform_get_irq_byname_optional(pdev, name);
if (ret <= 0)
--
2.47.1
