Re: [PATCH v7 8/8] PCI/AER: Add prefixes to printouts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Dec 2024, Yazen Ghannam wrote:

> On Tue, Dec 17, 2024 at 03:53:58PM +0200, Ilpo Järvinen wrote:
> > Only part of the AER diagnostic printouts use "AER:" prefix because
> > they use low-level pci_printk() directly to allow selecting level.
> > 
> > Add "AER:" prefix to lines that are printed with pci_printk().
> 
> Can we please include the "HW_ERR" prefix also? IMO, it would make the
> kernel messages more consistent if all hardware error info had it.

While I'm not against your suggestion, it doesn't belong into this patch 
as there are other lines beyond those touched in this patch that would 
need to have HW_ERR as well.

I think I'll just drop this patch from this series and move it into the 
pci_printk() series to avoid the inter-series conflict. Adding the HW_ERR 
change would conflict badly with Karolina Stolarek's series so I'm not 
sure if I want to pursue that change at this point (it's only my todo 
list so it won't get forgotten).

-- 
 i.

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux