Hi Rob, > -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Tuesday, December 17, 2024 8:31 PM > To: Havalige, Thippeswamy <thippeswamy.havalige@xxxxxxx> > Cc: bhelgaas@xxxxxxxxxx; lpieralisi@xxxxxxxxxx; kw@xxxxxxxxx; > manivannan.sadhasivam@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > linux-pci@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; jingoohan1@xxxxxxxxx; Simek, Michal > <michal.simek@xxxxxxx>; Gogada, Bharat Kumar > <bharat.kumar.gogada@xxxxxxx> > Subject: Re: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb > slcr support > > On Fri, Dec 13, 2024 at 12:10:33PM +0530, Thippeswamy Havalige wrote: > > Add support for mdb slcr aperture that is only supported for AMD > > Versal2 devices. > > > > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@xxxxxxx> > > --- > > Changes in v3: > > ------------- > > - Introduced below changes in dwc yaml schema. > > Changes in v5: > > ------------- > > - Modify mdb_pcie_slcr as constant. > > --- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > index 548f59d76ef2..696568e81cfc 100644 > > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > @@ -113,6 +113,8 @@ properties: > > enum: [ smu, mpu ] > > - description: Tegra234 aperture > > enum: [ ecam ] > > + - description: AMD MDB PCIe slcr region > > + const: mdb_pcie_slcr > > Including the block name is redundant. Just 'slcr' is sufficient. Thank you for your comments, I'll update this in next patch. > > > allOf: > > - contains: > > const: dbi > > -- > > 2.34.1 > >
