On Mon, Dec 16, 2024 at 5:31 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > > Thanks! If nothing else comes up, I'll send you a v7 end of this week addressing > the two minor things I just replied to (remove wrong return statement in > iounmap() helper, `pci::DeviceId` naming and `Deref` impl). If you are going to send v7, then could you please take the chance to update `core::ffi::c_*` to `kernel::ffi::c_*`? (since we are migrating to our custom mapping -- `rust-next` completes the migration and enables the new mapping) I think you have only 3 cases here, and the change should not break anything in your case, i.e. it is just a replacement. Thanks! Cheers, Miguel
