On Thu, 12 Dec 2024, Yazen Ghannam wrote: > On Thu, Dec 12, 2024 at 08:50:26PM +0200, Ilpo Järvinen wrote: > > On Thu, 12 Dec 2024, Yazen Ghannam wrote: > > > @@ -95,7 +80,12 @@ static umode_t hsmp_is_sock_attr_visible(struct kobject *kobj, > > > * Static array of 8 + 1(for NULL) elements is created below > > > * to create sysfs groups for sockets. > > > * is_bin_visible function is used to show / hide the necessary groups. > > > + * > > > + * Validate the maximum number against MAX_AMD_NUM_NODES. If this changes, > > > + * then the attributes and groups below must be adjusted. > > > */ > > > +static_assert(MAX_AMD_NUM_NODES == 8); > > > > Please also add the #include for it. > > > > Just to confirm, you mean for static_assert()? > > #include <linux/build_bug.h> I saw you already made that change but yes, it is what I meant. -- i.