On Thu, Dec 12, 2024 at 10:25:53AM +0100, Niklas Cassel wrote: > Hello Mani, > > On Wed, Dec 11, 2024 at 01:31:01PM +0530, Manivannan Sadhasivam wrote: > > Hi, > > > > This series carries forward the effort to add Kselftest for PCI Endpoint > > Subsystem started by Aman Gupta [1] a while ago. I reworked the initial version > > based on another patch that fixes the return values of IOCTLs in > > pci_endpoint_test driver and did many cleanups. Since the resulting work > > modified the initial version substantially, I took over the authorship. > > > > This series also incorporates the review comment by Shuah Khan [2] to move the > > existing tests from 'tools/pci' to 'tools/testing/kselftest/pci_endpoint' before > > migrating to Kselftest framework. I made sure that the tests are executable in > > each commit and updated documentation accordingly. > > > > NOTE: Patch 1 is strictly not related to this series, but necessary to execute > > Kselftests with Qualcomm Endpoint devices. So this can be merged separately. > > Having to write a big NOTE is usually a hint that you should just have done > things differently :) > > If you need to respin this series, I strongly suggest that you send the > Qcom fix separately. It is totally independent, and should be merged ASAP. > Even though it is an independent fix, it is needed to get Kselftests (also the legacy ones) passing without failures. That's why I kept it as patch 1. Otherwise, someone may test it and report failures. > As you know, this series conflicts with: > https://lore.kernel.org/linux-pci/20241116032045.2574168-2-cassel@xxxxxxxxxx/ > > I don't see any reason why the above patch has not been merged yet, > but it would be really nice if the above could be picked up first, > so this series could also add a kselftest testcase for the above. > I was hoping that Greg would pick misc driver changes, but looking at the git log of this driver I got to know that the changes were picked by PCI folks only. @kw: Could you please pick the patch from Niklas? - Mani -- மணிவண்ணன் சதாசிவம்
