On Thu, Dec 12, 2024 at 08:02:33AM -0300, guilherme giacomo simoes wrote:
> The get_power and set_power fields is used, and only hardware_test is
> really not used. So, after commit
> 5b036cada481a7a3bf30d333298f6d83dfb19bed ("PCI: cpcihp: Remove unused
> struct cpci_hp_controller_ops.hardware_test") this TODO is completed.
The entire 40-char SHA-1 is overkill; use 12:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.12#n204
I see a test and call for .get_power() and .set_power(), but no actual
implementations, so I think they can be removed as well, can't they?
If so, I'll wait for that removal before applying this patch.
> Signed-off-by: guilherme giacomo simoes <trintaeoitogc@xxxxxxxxx>
In
https://lore.kernel.org/r/20241014131917.324667-1-trintaeoitogc@xxxxxxxxx,
you capitalized your names. What's your preference? I'd like to use
your name correctly and consistently.
> ---
> drivers/pci/hotplug/TODO | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pci/hotplug/TODO b/drivers/pci/hotplug/TODO
> index 92e6e20e8595..7397374af171 100644
> --- a/drivers/pci/hotplug/TODO
> +++ b/drivers/pci/hotplug/TODO
> @@ -2,10 +2,6 @@ Contributions are solicited in particular to remedy the following issues:
>
> cpcihp:
>
> -* There are no implementations of the ->hardware_test, ->get_power and
> - ->set_power callbacks in struct cpci_hp_controller_ops. Why were they
> - introduced? Can they be removed from the struct?
> -
> * Returned code from pci_hp_add_bridge() is not checked.
>
> cpqphp:
> --
> 2.34.1
>
