The period at the end of the subject doesn't match the common practice. On Thu, Nov 14, 2024 at 4:05 AM Zhou Shengqing <zhoushengqing@xxxxxxxxxxx> wrote: > > Per PCI Firmware Specification Revision 3.3 Table 4-7 _DSM Definitions > for PCI. Preserve PCI Boot Configuration Initial Revision ID is 2. But > the code is 1. > > v2:add Fixes tag. > > Fixes: 9d7d5db8e78e ("PCI: Move PRESERVE_BOOT_CONFIG _DSM evaluation to pci_register_host_bridge()") > Origin fixes: a78cf9657ba5 ("PCI/ACPI: Evaluate PCI Boot Configuration _DSM") What does this mean? > > Signed-off-by: Zhou Shengqing <zhoushengqing@xxxxxxxxxxx> > --- > drivers/pci/pci-acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > index af370628e583..7a4cad0c1f00 100644 > --- a/drivers/pci/pci-acpi.c > +++ b/drivers/pci/pci-acpi.c > @@ -132,7 +132,7 @@ bool pci_acpi_preserve_config(struct pci_host_bridge *host_bridge) > */ > obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(&host_bridge->dev), > &pci_acpi_dsm_guid, > - 1, DSM_PCI_PRESERVE_BOOT_CONFIG, > + 2, DSM_PCI_PRESERVE_BOOT_CONFIG, > NULL, ACPI_TYPE_INTEGER); > if (obj && obj->integer.value == 0) > return true; > -- This looks like a genuine fix, but I think it is PCI material.