On Mon, Nov 18, 2024 at 09:04:58AM +0100, Lorenzo Bianconi wrote: > Since mtk_pcie_en7581_power_up() runs in non-atomic context, rely on > msleep() routine instead of mdelay(). > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index f47c0f2995d94ea99bf41146657bd90b87781a7c..69f3143783686e9ebcc7ce3dff1883fa6c80d0f4 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -926,7 +926,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > * Wait for the time needed to complete the bulk assert in > * mtk_pcie_setup for EN7581 SoC. > */ > - mdelay(PCIE_EN7581_RESET_TIME_MS); > + msleep(PCIE_EN7581_RESET_TIME_MS); > > /* > * Unlike the other MediaTek Gen3 controllers, the Airoha EN7581 > @@ -954,7 +954,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > * Wait for the time needed to complete the bulk de-assert above. > * This time is specific for EN7581 SoC. > */ > - mdelay(PCIE_EN7581_RESET_TIME_MS); > + msleep(PCIE_EN7581_RESET_TIME_MS); > > /* MAC power on and enable transaction layer clocks */ > reset_control_deassert(pcie->mac_reset); > > -- > 2.47.0 > -- மணிவண்ணன் சதாசிவம்