在 2024/11/21 17:27, Lukas Wunner 写道:
On Wed, Nov 20, 2024 at 08:43:28PM +0800, Shuai Xue wrote:
$ echo 1 > /sys/kernel/debug/tracing/events/hotplug/pci_hp_event/enable
^^^^^^^
I think this should now be "pci_hotplug" because you've renamed the
TRACE_SYSTEM in v3.
Yes, you are right. Will fix it.
I'm wondering if we'll have other categories besides "pci_hp_event"
below "pci_hotplug". Maybe not. Is it possible to omit the "pci_hotplug"
and make "pci_hp_event" top level? Or should this be grouped below "pci"
instead of "pci_hotplug"? I'm somewhat at a loss here as I'm not
familiar with the conventions used in the tracing subsystem.
Sure, I can reorganize the directory. You have two optional proposals:
1. /sys/kernel/debug/tracing/events/pci_hp_event
2. /sys/kernel/debug/tracing/events/pci/pci_hp_event
I personally prefer the second approach. However, I'll defer the final decision
to the tracing subsystem maintainer, considering their expertise and
familiarity with the existing conventions.
From a PCI hotplug perspective, this patch LGTM, so:
Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
Thank you.
Best Regards,
Shuai
