On 07/09/2012 05:49 AM, Shengzhou Liu wrote: > On some platforms, in RC mode, root port has neither MSI/MSI-X nor INTx > interrupt generated, which are available only in EP mode on those platform. > In this case, we try to use other interrupt if supported (i.e. there is the > shared error interrupt on platform P1010, P3041, P4080, etc) to have AER, > Hot-plug, etc, services to work. > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@xxxxxxxxxxxxx> > --- > Documentation/kernel-parameters.txt | 4 ++++ > drivers/pci/pcie/portdrv_core.c | 19 +++++++++++++++++++ > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index a92c5eb..af97c81 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -2218,6 +2218,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > nomsi Do not use MSI for native PCIe PME signaling (this makes > all PCIe root ports use INTx for all services). > > + pcie_irq= [PCIE] Native PCIe root port interrupt options: > + other Try to use other interrupt when root port has > + neither MSI/MSI-X nor INTx support. Why does the user need to specify this? Shouldn't this be a matter of communication between kernel internals? > @@ -216,6 +227,14 @@ static int init_service_irqs(struct pci_dev *dev, int *irqs, int mask) > if (!pci_enable_msi(dev) || dev->pin) > irq = dev->irq; > > + /* > + * On some platforms, root port has neither MSI/MSI-X nor INTx > + * interrupt support in RC mode, so try to use other interrupt(i.e. > + * shared interrupt if supported). > + */ > + else if (port_other_interrupt_enabled && dev->irq) > + irq = dev->irq; Is there any reason to not use dev->irq if it is non-zero? -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
