On Thu, Nov 14, 2024 at 12:41:13PM -0600, Bowman, Terry wrote:
> On 11/14/2024 10:44 AM, Lukas Wunner wrote:
> > On Wed, Nov 13, 2024 at 03:54:19PM -0600, Terry Bowman wrote:
> > > @@ -1115,8 +1131,11 @@ static void pci_aer_handle_error(struct pci_dev *dev, struct aer_err_info *info)
> > >
> > > static void handle_error_source(struct pci_dev *dev, struct aer_err_info *info)
> > > {
> > > - cxl_handle_error(dev, info);
> > > - pci_aer_handle_error(dev, info);
> > > + if (is_internal_error(info) && handles_cxl_errors(dev))
> > > + cxl_handle_error(dev, info);
> > > + else
> > > + pci_aer_handle_error(dev, info);
> > > +
> > > pci_dev_put(dev);
> > > }
> >
> > If you just do this at the top of cxl_handle_error()...
> >
> > if (!is_internal_error(info))
> > return;
> >
> > ...you avoid the need to move is_internal_error() around and the
> > patch becomes simpler and easier to review.
>
> If is_internal_error()==0, then pci_aer_handle_error() should be called
> to process the PCIe error.
You're absolutely right, I missed that, sorry for the noise.
Thanks,
Lukas
