On Wed, 13 Nov 2024, Bjorn Helgaas wrote: > [+cc Bart, Amit, Neil, Caleb] > > On Wed, Oct 23, 2024 at 05:19:04PM -0500, Bjorn Helgaas wrote: > > On Fri, Oct 18, 2024 at 05:47:46PM +0300, Ilpo Järvinen wrote: > > > This series adds PCIe bandwidth controller (bwctrl) and associated PCIe > > > cooling driver to the thermal core side for limiting PCIe Link Speed > > > due to thermal reasons. PCIe bandwidth controller is a PCI express bus > > > port service driver. A cooling device is created for each port the > > > service driver finds to support changing speeds. > > > > drivers/pci/pcie/bwctrl.c | 366 ++++++++++++++++++ > > > include/linux/pci-bwctrl.h | 28 ++ > > > tools/testing/selftests/pcie_bwctrl/Makefile | 2 + > > > .../pcie_bwctrl/set_pcie_cooling_state.sh | 122 ++++++ > > > .../selftests/pcie_bwctrl/set_pcie_speed.sh | 67 ++++ > > > Applied to pci/bwctrl for v6.13, thanks Ilpo (and Alexandru, for the > > bandwidth notification interrupt support)! > > How attached are we to "bwctrl" and "pwrctl" as the names? > > I just noticed that we have "ctrl" for bandwidth control but "ctl" for > power control, which is slightly annoying to keep straight. > > "ctrl" is more common in the tree: > > $ find -name \*ctrl\*[ch] | wc -l > 691 > $ find -name \*ctl\*[ch] | wc -l > 291 > > so I would prefer that, although "pwrctl" is already in the tree (as > of v6.11), so it would be more disruptive to change it than to rename > "bwctrl". I personally don't mind what the name is. However, what I've noted is that visually those two are so similar that my brains will mix them on a glance anyway. Maybe the length difference would help on that confusion too, remains to be seen. -- i.
