Hello, [...] > > I suppose that "data->mode" will default to zero for v3.65a prior to > > this commit, corresponding to "DW_PCIE_UNKNOWN_TYPE" rather than the > > correct value of "DW_PCIE_RC_TYPE". Since I don't have an SoC with the > > v3.65a version of the controller, I cannot test it out, but I presume > > that the "INVALID device type 0" error will be displayed. Though the probe > > will not fail since the "default" case doesn't return an error code, the > > controller probably will not be functional as the configuration associated > > with the "DW_PCIE_RC_TYPE" case has been skipped. Hence, I believe that > > this fix should be backported. > > I guess nobody really cares too much since it's been broken for almost > four years. > > But indeed, sounds like it should have a stable tag and maybe a commit > log hint about what the failure looks like. Added Cc for stable releases. Siddharth, let me know how to update the commit log per Bjorn feedback, so I can do it directly on the branch. Thank you! Krzysztof
