On Tue, Nov 5, 2024 at 11:44 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, 4 Nov 2024 14:15:07 -0600 > Rob Herring <robh@xxxxxxxxxx> wrote: > > ... > > > With those modifications, the LAN966x PCI device is working on x86 systems. > > > > That's nice, but I don't have a LAN966x device nor do I want one. We > > already have the QEMU PCI test device working with the existing PCI > > support. Please ensure this series works with it as well. > > > > I will check. > > Can you confirm that you are talking about this test: > https://elixir.bootlin.com/linux/v6.12-rc6/source/drivers/of/unittest.c#L4188 > > The test needs QEMU with a specific setup and I found this entry point: > https://lore.kernel.org/all/fa208013-7bf8-80fc-2732-814f380cebf9@xxxxxxx/ Yes, that's it. > Do you have an "official" QEMU setup on your side to run the test or any > other pointers related to the QEMU command/setup you use? No, it's just something based on what you linked. Here's what I have: qemu-system-aarch64 -machine virt -cpu cortex-a72 -machine type=virt -nographic -smp 1 -m 2048 -kernel ../linux.git/arch/arm64/boot/Image --append console=ttyAMA0 -device pcie-root-port,port=0x10,chassis=9,id=pci.9,bus=pcie.0,multifunction=on,addr=0x3 -device pcie-root-port,port=0x11,chassis=10,id=pci.10,bus=pcie.0,addr=0x3.0x1 -device x3130-upstream,id=pci.11,bus=pci.9,addr=0x0 -device xio3130-downstream,port=0x0,chassis=11,id=pci.12,bus=pci.11,multifunction=on,addr=0x0 -device i82801b11-bridge,id=pci.13,bus=pcie.0,addr=0x4 -device pci-bridge,chassis_nr=14,id=pci.14,bus=pci.13,addr=0x0 -device pci-testdev,bus=pci.12,addr=0x0 Of course, you'll need a few changes to use ACPI. Rob