On Mon, Nov 04, 2024 at 03:23:29PM +0100, Borislav Petkov wrote: > On Wed, Oct 23, 2024 at 05:21:43PM +0000, Yazen Ghannam wrote: > > diff --git a/arch/x86/include/asm/amd_node.h b/arch/x86/include/asm/amd_node.h > > index 419a0ad13ef2..8e473a293706 100644 > > --- a/arch/x86/include/asm/amd_node.h > > +++ b/arch/x86/include/asm/amd_node.h > > @@ -30,4 +30,10 @@ static inline u16 amd_num_nodes(void) > > return topology_amd_nodes_per_pkg() * topology_max_packages(); > > } > > > > +/* Caller must ensure the input is an AMD node device. */ > > You can ensure that yourself by checking the PCI vendor in the PCI device, > right? > > IOW, pdev->vendor... > Yes, there can be a vendor and/or bus,device check. I'll add them. Thanks, Yazen