On Tue, 2012-06-26 at 09:18 -0400, Chris Metcalf wrote: > On 6/25/2012 11:32 PM, Myron Stowe wrote: > > The PCI core provides a generic (__weak) 'pcibios_setup()' routine > > that can be used by all architectures as a default. Drop tile's > > architecture specific version in favor of that as it does not need to be > > over-ridden. > > > > Signed-off-by: Myron Stowe <myron.stowe@xxxxxxxxxx> > > --- > > > > arch/tile/kernel/pci.c | 10 ---------- > > 1 files changed, 0 insertions(+), 10 deletions(-) > > Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxx> > > In our internal tree we have x86-like support for "pci=off" here. When I > push that I can just push it as a new function to override the removed one, > so I'm happy with your change as proposed. Yes, that should be fine. Just an FYI - when you introduce the over-ride, I believe that it should be __init and not __devinit as the previous tile version of 'pcibios_setup()' was. > But perhaps it would make sense > to move the support for "pci=off" to common code, since multiple > architectures handle this the same way? Looking at the tree I only see three of the architectures currently using/implementing "pci=off" (four with the 'tile' addition). Perhaps there is a way to avoid such but it seems like adding this to the core would require introducing the global variable 'pci_probe' which seems like unnecessary pollution? Myron -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
