Re: [PATCH] pci:endpoint Remove redundant returns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 04, 2024 at 10:35:00PM +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> [+Cc linux-pci mailing list]

Where did this patch come from?  I don't see it on the mailing list,
so there's no signed-off-by chain for it, and the Link in the commit
doesn't go to the patch posting.

Please post all PCI-related patches to linux-pci@xxxxxxxxxxxxxxx.

> > In fact, void function return statements are not generally useful.
> 
> ... unless used within the code for control flow. :)
> 
> >  	dma_release_channel(epf_test->dma_chan_rx);
> >  	epf_test->dma_chan_rx = NULL;
> > -
> > -	return;
> 
> Makes sense.
> 
> For reference, this surplus return statement was added in the commit
> 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA
> capabilities").
> 
> 	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux