On Wed, 2012-06-27 at 12:15 -0600, Bjorn Helgaas wrote: > > This patch appears to have multiple unrelated changes: > > - change "struct pci_bus *bus" to "struct pci_bus *root_bus" > - change find_pci_host_bridge() argument from dev to bus > - fiddle with pcibios_bus_to_resource() and > pcibios_resource_to_bus() > > These should be split out to make your patches easier to review. > > What's the rationale for preferring the pci_bus over the pci_dev? We really want to stop doing that crap and put a pointer to the host bridge directly in each pci_dev (and maybe pci_bus). We already do that on powerpc via sysdata (pointing to our private structure but the plan is to move that toward struct pci_host_bridge eventually). We'll need host bridge access to deal with resource "offsets" in a few more places and having to do a lookup is just a pain. For example, see my earlier email about the issues with the way we calculate the minimum address to assign devices. This is currently broken when we have an offset and to fix it we'll probably want to deal with offsets all the way down in the resource allocation code. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
